[Webkit-unassigned] [Bug 74864] There is additional space not belonged to a table between the table cells

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74864





--- Comment #11 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-08-06 03:05:28 PST ---
(In reply to comment #9)
> (In reply to comment #7)
> > Created an attachment (id=156637)
 --> (https://bugs.webkit.org/attachment.cgi?id=156637&action=review) [details] [details]
> > Patch
> 
> I can't provide an r+ as a non-reviewer, but it looks good to me now and  the test-case is very informative.

(In reply to comment #8)
> (From update of attachment 156530 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156530&action=review
> 
> > Source/WebCore/rendering/RenderTableSection.cpp:1121
> >      // Find the first columnt that starts after rect left.
> 
> Btw, feel free to fix my typo.

Done! and thanks for your positive feedback. :)
Also, I was looking at perhaps raising another bug which removes the following FIXME from the code (in RenderTableSection::spannedRows()):

 // FIXME: Upper_bound might not be the correct algorithm here since it might skip empty rows, but it is
    // consistent with behavior in the former point based hit-testing (but inconsistent with spannedColumns).

I could add testcases with empty <TR>s to verify upper_bound() algorithm's behavior.
Would appreciate your thoughts on the same.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.