[Webkit-unassigned] [Bug 92942] Add DeviceProximityEvent interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92942


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156632|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #10 from Kentaro Hara <haraken at chromium.org>  2012-08-06 02:36:11 PST ---
(From update of attachment 156632)
View in context: https://bugs.webkit.org/attachment.cgi?id=156632&action=review

Looks OK.

Sorry for the iterative comments. A couple of nits in your test.

> LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html:14
> +    document.getElementById('result').innerHTML = "PASS";

Nit: you could use testPassed()

> LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html:24
> +    document.getElementById('result').innerHTML = "FAIL... deviceproximity event doesn't appear to be enabled or implemented.";

Nit: you could use testFailed()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.