[Webkit-unassigned] [Bug 89840] [WK2][EFL] Implement accelerated compositing on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89840





--- Comment #31 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-08-05 19:01:47 PST ---
(From update of attachment 155194)
View in context: https://bugs.webkit.org/attachment.cgi?id=155194&action=review

> Source/WebKit2/UIProcess/API/efl/EflViewportHandler.cpp:58
> +    renderer->paintToCurrentGLContext(matrix, 1.0f, rect);

Though there was a little argument in EFL port, webkit coding style guides that floating point literals aren't appeneded .0, .f and .0f to .

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1328
> +    EWK_VIEW_PRIV_GET(smartData, priv);

To prevent crash, I think you need to use "EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv)"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.