[Webkit-unassigned] [Bug 93127] Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93127





--- Comment #13 from Nasko Oskov <nasko at chromium.org>  2012-08-03 16:18:20 PST ---
(From update of attachment 156470)
View in context: https://bugs.webkit.org/attachment.cgi?id=156470&action=review

>> Source/WebKit/chromium/public/WebFrame.h:134
>>      virtual WebString name() const = 0;
> 
> Should we add a comment about how we're going to change this from uniqueName to assignedName ?

Done.

>>> Source/WebKit/chromium/public/WebFrameClient.h:418
>>>          WebDOMMessageEvent) { return false; }
>> 
>> This seems backwards.  willCheckAndDispatchMessageEvent is called by WebKit, which means the new version needs to forward to the old version, not vice versa.
> 
> I thought it calls through Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp, which I've modified. Is it also called directly by WebKit?

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.