[Webkit-unassigned] [Bug 93127] Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93127





--- Comment #8 from Adam Barth <abarth at webkit.org>  2012-08-03 15:52:42 PST ---
(From update of attachment 156470)
View in context: https://bugs.webkit.org/attachment.cgi?id=156470&action=review

> Source/WebKit/chromium/public/WebFrame.h:134
>      // The name of this frame.
>      virtual WebString name() const = 0;

Should we add a comment about how we're going to change this from uniqueName to assignedName ?

> Source/WebKit/chromium/public/WebFrameClient.h:418
>      virtual bool willCheckAndDispatchMessageEvent(
>          WebFrame* source,
>          WebSecurityOrigin target,
> +        WebDOMMessageEvent event)
> +    {
> +        return willCheckAndDispatchMessageEvent(source, 0, target, event);
> +    }
> +
> +    virtual bool willCheckAndDispatchMessageEvent(
> +        WebFrame* sourceFrame,
> +        WebFrame* targetFrame,
> +        WebSecurityOrigin target,
>          WebDOMMessageEvent) { return false; }

This seems backwards.  willCheckAndDispatchMessageEvent is called by WebKit, which means the new version needs to forward to the old version, not vice versa.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.