[Webkit-unassigned] [Bug 93127] Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 3 09:56:55 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=93127





--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-08-03 09:56:54 PST ---
(From update of attachment 156390)
View in context: https://bugs.webkit.org/attachment.cgi?id=156390&action=review

>> Source/WebKit/chromium/public/WebFrameClient.h:112
>>      // This frame is about to be closed.
> 
> Can you add a comment explaining the lifecycle of a frame w.r.t. these functions?  Presumably didCreateFrame and frameDetached are always called at the beginning and end of the lifecycle, respectively.  From our discussion, it sounds like willClose is called before frameDetached, but only in some situations...

we need to remove willClose from the API.  it is never what you want.  frameDetached should probably also be renamed at some point to didDetachFrame.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list