[Webkit-unassigned] [Bug 92739] Web Inspector: Protocol: Add "namedFlowCreated" and "namedFlowRemoved" events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92739





--- Comment #5 from Pavel Feldman <pfeldman at chromium.org>  2012-08-03 02:31:56 PST ---
(From update of attachment 156285)
View in context: https://bugs.webkit.org/attachment.cgi?id=156285&action=review

Couple more nits, one of them depends on another bug Alexander is filing.

> Source/WebCore/dom/WebKitNamedFlowCollection.cpp:83
> +#if ENABLE(INSPECTOR)

You should not surround Instrumentation calls with #if ENABLE.

> Source/WebCore/dom/WebKitNamedFlowCollection.cpp:101
> +#if ENABLE(INSPECTOR)

ditto

> Source/WebCore/inspector/InspectorCSSAgent.cpp:540
> +    int nodeId = m_domAgent->pushNodePathToFrontend(document);

pushChildNodesToFrontend implies there is a front-end.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:542
> +    if (m_frontend)

You should not make this check. In fact, you should not be getting into this method when there is no m_frontend. It is a bug in InspectorCSSAgent that needs to be addressed. I'll ask apavlov@ to handle it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.