[Webkit-unassigned] [Bug 93019] Web Inspector: WebInspector.linkifyStringAsFragment gives wrong typeof lineNumber

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93019


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #156144|review?                     |review-
               Flag|                            |




--- Comment #2 from Vsevolod Vlasov <vsevik at chromium.org>  2012-08-03 00:26:09 PST ---
(From update of attachment 156144)
View in context: https://bugs.webkit.org/attachment.cgi?id=156144&action=review

> Source/WebCore/inspector/front-end/ResourceUtils.js:-251
> -            urlNode.lineNumber = lineNumber;

linkifier function is passed to linkifyStringAsFragmentWithCustomLinkifier as a parameter. I think we should fix linkifyStringAsFragmentWithCustomLinkifier instead to always pass the number to linkifier.

> LayoutTests/inspector/debugger/linkifier.html:44
> +        var linkifyMe = "at triggerError (http://fiddle.jshell.net/Ad2Rr/4/show/:22:11)";

nit: This real life url is distracting, I would use something like http://localhost/:22:11 instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.