[Webkit-unassigned] [Bug 53003] Web Inspector: [JSC] implement setting breakpoints by line:column

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53003





--- Comment #70 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-08-02 20:40:38 PST ---
(In reply to comment #57)
> Created an attachment (id=155774)
 --> (https://bugs.webkit.org/attachment.cgi?id=155774&action=review) [details]
> Patch

update patch to catch up the newest code.
(In reply to comment #69)
> (In reply to comment #68)
> > Created an attachment (id=156045)
 --> (https://bugs.webkit.org/attachment.cgi?id=156045&action=review) [details] [details]
> > Patch
> 
> What does this do to fix the crashes in the previous patch?

I need to verify on my local Mac build again. So far, I think the reason is "JSC::Debugger", in my patch the interfaces like "callEvent" of "JSC::Debugger" are added one parameter. The class of Mac porting WebScriptDebugger derived from "JSC::Debugger" and override these interfaces. I missed the Mac porting, I should at least changed the interfaces of WebScriptDebugger and test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.