[Webkit-unassigned] [Bug 92942] Add DeviceProximityEvent interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 2 19:11:04 PDT 2012


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #155985|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #4 from Kentaro Hara <haraken at chromium.org>  2012-08-02 19:11:02 PST ---
(From update of attachment 155985)
View in context: https://bugs.webkit.org/attachment.cgi?id=155985&action=review

WebCore implementation looks good. Marking r- due to insufficient tests.

> Source/WebCore/ChangeLog:9
> +        Add DeviceProximityEvent interface of Proximity Events.
> +        And add onwebkitdeviceproximity event handler to the DOMWindow.

Please add the spec link to the ChangeLog.

> Source/WebCore/Modules/proximity/DeviceProximityEvent.h:45
> +        return adoptRef(new DeviceProximityEvent);

Nit: new DeviceProximityEvent()

> LayoutTests/ChangeLog:8
> +        Add a test case to create DeviceProximityEvent and to check onwebkitdeviceproximity.

- Let's add test cases for constructor. Look at tests under fast/events/constructors/. Let's add fast/events/constructors/device-proximity-event.html

- Can you test if the DeviceProximityEvent bubbles up correctly?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list