[Webkit-unassigned] [Bug 90375] Parallel image decoders

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90375





--- Comment #65 from Huang Dongsung <luxtella at company100.net>  2012-08-02 19:10:05 PST ---
(In reply to comment #63)

When I pushed the Publish button in Review Patch, Bugzilla said "You may not search, or create saved searches, without any search terms."
So, I comment by hand.


> Source/WebCore/ChangeLog:3
> +    BitmapImage::currentFrameOrientation() shouldn't decode the current frame

You already made BitmapImage::currentFrameOrientation() and BitmapImage::currentFrameHasAlpha() not decode the current frame in the previous patch.
However, this patch is little bit different. :)



> Source/WebCore/platform/graphics/ImageSource.cpp:193
> -     return !frameIsCompleteAtIndex(index)
> -         || m_decoder->frameBufferAtIndex(index)->hasAlpha();
> +    return !m_decoder->isAllDataReceived()
> +        || m_decoder->frameHasAlphaAtIndex(index);

We discussed frameIsCompleteAtIndex also does not trigger decoding, but this patch seems frameIsCompleteAtIndex can trigger decoding.
I think you concern that GIF animation need to trigger decoding when calling frameIsCompleteAtIndex.
There are only two places which need to decode when calling frameIsCompleteAtIndex. Both are in BitmapImage::startAnimation.
How about change the code like this.

in BitmapImage::startAnimation about 433 line

    ensureFrameIsCached(nextFrame);          <-- add this line.
    if (!m_allDataReceived && !frameIsCompleteAtIndex(nextFrame)) {
        return;
    }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.