[Webkit-unassigned] [Bug 92040] Delete text from password does nothing, proposed fix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92040





--- Comment #24 from Ryosuke Niwa <rniwa at webkit.org>  2012-08-02 17:59:55 PST ---
(From update of attachment 156220)
View in context: https://bugs.webkit.org/attachment.cgi?id=156220&action=review

> LayoutTests/editing/deleting/password-delete-contents-expected.txt:3
> +PASS textField.value == desiredString is true

This output doesn't tell us what we're testing.

> LayoutTests/editing/deleting/password-delete-contents.html:26
> +    textField.value = "helllo";
> +    textField.focus();
> +    textField.selectionStart = 3;
> +    textField.selectionEnd = 4;
> +
> +    testRunner.execCommand("Delete",false,null)
> +    shouldBeTrue('textField.value == desiredString');

It should have been better to include the test code in should* itself as in:
shouldBe("passwordField.value='helllo'; passwordField.setSelectionRange(3, 4); testRunner.execCommand('Delete', false, null); passwordField.value", "'hello'");
so that you can see the test code itself in the expected result.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.