[Webkit-unassigned] [Bug 92040] Delete text from password does nothing, proposed fix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92040





--- Comment #21 from Ryosuke Niwa <rniwa at webkit.org>  2012-08-02 15:39:07 PST ---
(In reply to comment #20)
> Thank you Ryosuke, I'll make sure I dont make that typo again hehehehe.
> 
> This is my first contrib, could you please explain a little about writing a WebKit API test?

http://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI

But it appears that we can test this from a layout test.

> Should I write a LayoutTest for this?

Yeah, you can call testRunner.execCommand("delete", false, null) (as opposed to document.execCommand("delete", false, null) after setting the focus on a password field).

> And one more thing: after giving the r+ to the patch, should I ask someone to commit it? or can you do it?

Yes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.