[Webkit-unassigned] [Bug 91089] [NRWT] runs platform specific tests that it shouldn't with --force

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 2 14:03:00 PDT 2012


--- Comment #12 from Dirk Pranke <dpranke at chromium.org>  2012-08-02 14:02:58 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > Oh, hmm, I thought of something I don't like about your suggestion. The way things are currently implemented, tests() returns the same list independent of the port; that way the statistics we report for total # of files is the same across ports, and just the # of tests that skip varies, and so changing that seems less good. In particular, when you have multiple variants of the same port (e.g., chromium, or qt), it's nice to be able to compare how many tests are being skipped on each variant.
> > 
> > Although, re-thinking it, this isn't actually quite true with the addition of virtual test suite, since ports with different lists of virtual suites will have different numbers of tests. Currently, the only port that uses virtual tests is chromium, but at least there all of the variants use the same list of suites, so at least I keep the last sentence true.
> > 
> > So, I still have a slight preference for leaving things the way they are, I guess. But if you'd strongly prefer to make the change, I won't be that upset by it.
> Ok, than I think we should get rid of platform tests instead.

I actually like the platform tests concept, and it feels ugly to have to explicitly list in files tests that should be Skipped by definition (even though that's what Chromium has historically done). 

If WONTFIXing this isn't acceptable, I'd prefer making the change in comment #4 to having to explicitly move the platform-specific tests into a "not-platform dir but really it's a platform dir" and then skip things. That feels like a bad workaround.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list