[Webkit-unassigned] [Bug 91632] Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91632


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155757|review?                     |review-
               Flag|                            |




--- Comment #12 from Pavel Feldman <pfeldman at chromium.org>  2012-08-02 12:05:42 PST ---
(From update of attachment 155757)
View in context: https://bugs.webkit.org/attachment.cgi?id=155757&action=review

Looks good. A couple of nits inline.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:565
> +    if (!m_highlightNode && !m_highlightRect)

I think now node and rect highlighting are independent first class citizens. You should treat them separately (as you treat drawPausedInDebugger)

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1009
> +            *errorString = "Null pointer for highlightInspectorObject in InspectorDOMAgent::setSearchingForNode";

"Internal error: highlight configuration parameter is missing"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.