[Webkit-unassigned] [Bug 92739] Web Inspector: Protocol: Add "namedFlowCreated" and "namedFlowRemoved" events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92739


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155521|review?                     |review-
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2012-08-02 12:00:32 PST ---
(From update of attachment 155521)
View in context: https://bugs.webkit.org/attachment.cgi?id=155521&action=review

> Source/WebCore/inspector/InspectorCSSAgent.cpp:540
> +    int nodeId = m_domAgent->boundNodeId(static_cast<Node*>(document));

There is no need to cast document to Node, Document is a Node.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:541
> +    if (!nodeId)

I am not sure this is what you want. You only report creation / destruction of the flows when document node on the front-end is visible. So every time document node is received on the front-end (user expanded an <iframe> tag), you want to query for document's existing named flows and dispatch corresponding events.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:550
> +    int nodeId = m_domAgent->boundNodeId(static_cast<Node*>(document));

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.