[Webkit-unassigned] [Bug 91089] [NRWT] runs platform specific tests that it shouldn't when invoked on a directory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 2 11:22:40 PDT 2012


--- Comment #10 from Dirk Pranke <dpranke at chromium.org>  2012-08-02 11:22:39 PST ---
Oh, hmm, I thought of something I don't like about your suggestion. The way things are currently implemented, tests() returns the same list independent of the port; that way the statistics we report for total # of files is the same across ports, and just the # of tests that skip varies, and so changing that seems less good. In particular, when you have multiple variants of the same port (e.g., chromium, or qt), it's nice to be able to compare how many tests are being skipped on each variant.

Although, re-thinking it, this isn't actually quite true with the addition of virtual test suite, since ports with different lists of virtual suites will have different numbers of tests. Currently, the only port that uses virtual tests is chromium, but at least there all of the variants use the same list of suites, so at least I keep the last sentence true.

So, I still have a slight preference for leaving things the way they are, I guess. But if you'd strongly prefer to make the change, I won't be that upset by it.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list