[Webkit-unassigned] [Bug 92975] Introduce InternalsClient for handling port specific details as resource urls etc. for Internals object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92975





--- Comment #3 from Vivek Galatage <vivekgalatage at gmail.com>  2012-08-02 06:46:32 PST ---
(In reply to comment #2)
> (From update of attachment 156062 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156062&action=review
> 
> > Source/WebCore/testing/InternalsClient.h:40
> > +PassOwnPtr<InternalsClient> provideInternalsClient();
> 
> What prevents you from adding InternalsClient* a parameter to Internals::Internals ?

:) I thought of doing so. As I was rushing back home from office, I thought quickly upload the patch and work on it from home. I will correct this one. It would need modifications to WebCoreTestSupport::injectInternalsObject signature as WebCoreTestSupport::injectInternalsObject(JSContextRef context, InternalsClient* client).  This function is being called from all the platform specific DumpRenderTree implementations. So its easy to pass the direct client implementation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.