[Webkit-unassigned] [Bug 92964] [EFL] Change return value of battey level

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 2 05:44:50 PDT 2012


Ryuan Choi <ryuan.choi at samsung.com> changed:

           What    |Removed                     |Added
 Attachment #156051|commit-queue?               |commit-queue-
               Flag|                            |

--- Comment #8 from Ryuan Choi <ryuan.choi at samsung.com>  2012-08-02 05:44:49 PST ---
(From update of attachment 156051)
View in context: https://bugs.webkit.org/attachment.cgi?id=156051&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests, no behavior changed.

I think that this comment is wrong.

This patch changes behavior but we can not make automated tests for this because we can not emulate E_Ukit.

> Source/WebCore/platform/efl/BatteryProviderEfl.cpp:155
> +    double level = property->val.d / 100;

I think that property of "Percentage" is not assigned yet.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list