[Webkit-unassigned] [Bug 92964] [EFL] Change return value of battey level

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92964





--- Comment #2 from Ryuan Choi <ryuan.choi at samsung.com>  2012-08-02 03:50:00 PST ---
(From update of attachment 156027)
View in context: https://bugs.webkit.org/attachment.cgi?id=156027&action=review

> Source/WebCore/platform/efl/BatteryProviderEfl.cpp:165
>          levelChanged = true;
>      level = property->val.d;
>  
> -    WTF::RefPtr<BatteryStatus> batteryStatus = BatteryStatus::create(charging, chargingTime, dischargingTime, level);
> +    WTF::RefPtr<BatteryStatus> batteryStatus = BatteryStatus::create(charging, chargingTime, dischargingTime, level / 100);

If then, should we compare with clientBatteryStatus->level() * 100 and property->val.d ?

IMO, you'd better to assign property->val.d / 100 to `level` to reduce confusion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.