[Webkit-unassigned] [Bug 92967] [GTK][WK2] Add API for suggested filename from a URI Response.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 2 03:20:27 PDT 2012


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #156024|review?                     |review-
               Flag|                            |

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-08-02 03:20:26 PST ---
(From update of attachment 156024)
View in context: https://bugs.webkit.org/attachment.cgi?id=156024&action=review

You should include a unit tests to check the new api added.

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:255
> + * Returns: the suggested filename for @response, as specified by

Don't use Returns: tag twice

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:259
> + * Returns: (transfer none): the suggested filename or %NULL if none

if none -> if not present

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:260
> + * Since: 2.0

Don't add Since tags for wk2 gtk api, since we haven't released a first stable version yet.

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.h:75
> +webkit_uri_response_get_suggested_filename (WebKitURIResponse *response);

parameter name should also be aligned with other methods

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list