[Webkit-unassigned] [Bug 92966] New: Web Inspector: rename reportMemoryUsage to reportDescendantMemoryUsage in StyleRuleBase descendants

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 2 02:48:40 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=92966

           Summary: Web Inspector: rename reportMemoryUsage to
                    reportDescendantMemoryUsage in StyleRuleBase
                    descendants
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yurys at chromium.org
                CC: timothy at apple.com, rik at webkit.org, keishi at webkit.org,
                    pmuellr at yahoo.com, joepeck at webkit.org,
                    pfeldman at chromium.org, yurys at chromium.org,
                    bweinstein at apple.com, apavlov at chromium.org,
                    loislo at chromium.org
        Depends on: 92748


Current implementation of StyleRuleBase::reportMemoryUsage has a switch by the rule type, then
casts it to the corresponding descendant type and calls reportMemoryUsage on it. This scheme
can be accidentally broken by adding another type to the switch: if the descendant doesn't
provide its own reportMemoryUsage implementation we will end up with recursive call to
StyleRuleBase::reportMemoryUsage. Compiler won't help us in that case. This can be fixed by
changing the name of the method that actually provides the memory instrumentation in the descendants.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list