[Webkit-unassigned] [Bug 92725] IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92725





--- Comment #16 from xingnan.wang at intel.com  2012-08-01 19:10:08 PST ---
(From update of attachment 155750)
View in context: https://bugs.webkit.org/attachment.cgi?id=155750&action=review

>> Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp:93
>> +#ifdef NDEBUG
> 
> These NDEBUG guards should not be necessary here. 
> 
> We use them in the "Int" tests due to ASSERTs that guard against using data with the high bit set (since the methods are not correctly using signed/unsigned types), but wanted to ensure the correct behavior in the test. (I can dig up the bug number if desired, there was a long discussion.)
> 
> The new decodeByte function correctly takes an unsigned char, though, so it doesn't matter here.

Removed this one.

>> Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp:708
>> +TEST(IDBLevelDBCodingTest, EncodeVarIntVSEncodeByteTest)
> 
> Thanks a bunch for adding this.

Thanks for your review, updated the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.