[Webkit-unassigned] [Bug 90375] Parallel image decoders

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 18:58:51 PDT 2012


--- Comment #57 from Hin-Chung Lam <hclam at google.com>  2012-08-01 18:58:47 PST ---
> I know Texmap well and I think we can overcome about Texmap. I can remove currentFrameHasAlpha() completely in the code related to Texmap.
> However, I have lack of knowledge about box shadow painting. My gut feeling still tells me by removing currentFrameHasAlpha() completely.
> Otherwise, clients could be confused whether they use currentFrameHasAlpha() or a platform specific function.

If we can remove this method that would be the best outcome.

This method is also used in LayerTreeCoordinator.cpp which is in WebKit2 and I have no knowledge of.

RenderImage's use of currentFrameHasAlpha comes from this change 91628 and 65030 is filed to return the correct value for PNG and GIF. I would check with Simon Fraser to see if it is okay to remove the optimization for RenderImage. (Just added him to this bug.)

> I want to try to remove meta data query functions based on your patch, and then refactory parallel image decoders on the preparation.
> parallel image decoders changes almost only ImageSource. I think parallel image decoders will get along with your async image decoder.
> If you don't mind, I will post a patch in several hours later.
> I am curious about the progress of your async image decoder, how we collaborate the preparation and how we commit our async and parallel image decoders.

Please go ahead and take the patch. We are still in the progress of refactoring, which is what we're discussing now. :)

I think once we are both happy with the refactoring we can put the refactoring patch up for review first. If you're happy trading patches with buganizer just like what we're doing now we can continue with this method.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list