[Webkit-unassigned] [Bug 92878] [GTK] Add WebKitNetworkResponse::suggested-filename property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92878





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-08-01 09:52:27 PST ---
(From update of attachment 155825)
View in context: https://bugs.webkit.org/attachment.cgi?id=155825&action=review

Looks good to me, apart from some style nits.

> Source/WebKit/gtk/webkit/webkitnetworkresponse.cpp:44
> +using namespace WebKit;
> +

This should really be just below the header list.

> Source/WebKit/gtk/webkit/webkitnetworkresponse.cpp:174
> +                                                        (GParamFlags)(WEBKIT_PARAM_READABLE)));

Should use a C++ cast here.

> Source/WebKit/gtk/webkit/webkitnetworkresponse.cpp:287
> +    g_return_val_if_fail(WEBKIT_IS_NETWORK_RESPONSE(response), NULL);

Instead of NULL use 0 in WebKit, unless it's the end of an argument list.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.