[Webkit-unassigned] [Bug 89122] [GStreamer] Audio device not closed after playing sound

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89122





--- Comment #11 from Philippe Normand <pnormand at igalia.com>  2012-08-01 07:40:29 PST ---
(From update of attachment 153280)
View in context: https://bugs.webkit.org/attachment.cgi?id=153280&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:327
>> +    }
> 
> What happens if m_mediaDuration is 0? What does that mean? Is that an error?

It means there's no duration in TIME available, it's not a case or error though.

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:363
>> +        return true;
> 
> Is it really safe to compare the different GstStates (which, I presume, are enum values) with inequalities?

Yes I think so. The GstState enum hasn't changed since the early gst 0.10 versions AFAIK. In gst 0.11/1.0 it hasn't changed either. This is one of the basic concepts of the framework.

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:367
>> +    GstStateChangeReturn ret = gst_element_set_state(m_playBin, newState);
> 
> ret -> setStateResult?

Ok I'll change that!

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-430
>> -
> 
> Why this change?

Hum good question, I need to check this one.

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:467
>>          return;
> 
> Why the extra check here? Even if the end is reached, why should we allow seeking to a position that is the same as the current playback position?

Ermm, good point! I guess this change can be removed. I'll check it again.

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1193
>>              m_paused = true;
> 
> It's a bit odd that pause() returns true when m_isReached is true, but m_paused is not true... I'm not sure I understand.

Right, maybe we can set m_paused on EOS if the media element is not looping.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.