[Webkit-unassigned] [Bug 92040] Delete text from password does nothing, proposed fix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92040





--- Comment #13 from Mike Fenton <mifenton at rim.com>  2012-08-01 06:08:50 PST ---
In the blackberry port, we encountered the same issue.

Our solution which has been working well is

diff --git a/Source/WebCore/editing/EditorCommand.cpp b/Source/WebCore/editing/EditorCommand.cpp
index a2f147e..bc637c8 100644
--- a/Source/WebCore/editing/EditorCommand.cpp
+++ b/Source/WebCore/editing/EditorCommand.cpp
@@ -1234,8 +1234,7 @@ static bool enabledDelete(Frame* frame, Event* event, EditorCommandSource source
 {
     switch (source) {
     case CommandFromMenuOrKeyBinding:
-        // "Delete" from menu only affects selected range, just like Cut but without affecting pasteboard
-        return enabledCut(frame, event, source);
+        return frame->editor()->canDelete();
     case CommandFromDOM:
     case CommandFromDOMWithUserInterface:
         // "Delete" from DOM is like delete/backspace keypress, affects selected range if non-empty,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.