[Webkit-unassigned] [Bug 92504] [EFL][WK2] Implement undo stack

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92504





--- Comment #6 from Michal Pakula vel Rutka <m.pakula at samsung.com>  2012-08-01 02:03:08 PST ---
(In reply to comment #4)
> (From update of attachment 154940 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154940&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        Add an undo stack for WebKit2 EFL basing on WebUndoController from QT port.
> 
> "QtWebUndoController from Qt port".
> 
> >> Source/WebKit2/UIProcess/efl/WebUndoControllerEfl.cpp:6
> >> +    This library is free software; you can redistribute it and/or
> > 
> > If possible, could you use BSD license instead of LGPL. I was told BSD is more useful.
> 
> Considering there are other copyright holders on this file (Nokia, Staikos), he cannot change license like that.
> 
> > Source/WebKit2/UIProcess/efl/WebUndoControllerEfl.h:32
> > +    void registerEditCommand(PassRefPtr<WebKit::WebEditCommandProxy>, WebKit::WebPageProxy::UndoOrRedo);
> 
> You don't need all the WebKit:: in this file.
> 

Done.

> > Source/WebKit2/UIProcess/efl/WebUndoControllerEfl.h:38
> > +    CommandVector m_undoStack;
> 
> Should probably be private.
> 
> > Source/WebKit2/UIProcess/efl/WebUndoControllerEfl.h:39
> > +    CommandVector m_redoStack;
> 
> Ditto.

Both moved to private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.