[Webkit-unassigned] [Bug 82955] NOT FOR REVIEW. Adds ability to take snapshot of partially occluded window

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 15:37:21 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82955





--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-04-02 15:37:16 PST ---
Attachment 135205 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:1146:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:117:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:117:  Use 0 instead of NULL.  [readability/null] [5]
Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:413:  Use 0 instead of NULL.  [readability/null] [5]
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:85:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:94:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:94:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 8 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list