[Webkit-unassigned] [Bug 84414] Expose a flag so that fullscreen video on android can work with FULLSCREEN_API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84414





--- Comment #20 from Min Qin <qinmin at chromium.org>  2012-04-30 19:38:12 PST ---
For android, fullscreen video is implemented by passing a java video surfaceView object to the webmediaplayer. As a consequence, NATIVE_FULLSCREEN_VIDEO means the fullscreen video is implemented by the native system view,  and is not implemented by any of the webkit code.

Probably USE makes more sense here, I will have another change to fix this,

(In reply to comment #19)
> (From update of attachment 139467 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139467&action=review
> 
> > Source/WebCore/platform/graphics/MediaPlayer.cpp:772
> > +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO) || ENABLE(NATIVE_FULLSCREEN_VIDEO)
> 
> Would you explain what is NATIVE_FULLSCREEN_VIDEO?
> Shouldn't it be a USE() flag instead of an ENABEL() flag?
> 
> http://trac.webkit.org/wiki/Porting%20Macros%20plan
> * USE() - use a particular third-party library or optional OS service
> * ENABLE() - turn on a specific feature of WebKit

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.