[Webkit-unassigned] [Bug 84306] [Qt][WK2] Fixed layers are shaking when zoom level is not 1.0 due to a rounding error.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84306





--- Comment #24 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-04-30 15:17:16 PST ---
(From update of attachment 139400)
View in context: https://bugs.webkit.org/attachment.cgi?id=139400&action=review

> Source/WebKit2/UIProcess/DrawingAreaProxy.h:95
> +    virtual void setVisibleContentsRect(const WebCore::IntRect& visibleContentsRect, float scale, const WebCore::FloatPoint& trajectoryVector, const WebCore::FloatPoint& = WebCore::FloatPoint()) { }

you can name the parameter here

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:83
> +    virtual void setVisibleContentsRect(const WebCore::IntRect& visibleContentsRect, float scale, const WebCore::FloatPoint& trajectory, const WebCore::FloatPoint& = WebCore::FloatPoint());

Use parameter name

> Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp:132
> +    dispatchUpdate(bind(&WebLayerTreeRenderer::setVisibleContentsRect, m_renderer.get(), rect, scale, accurateVisibleContentPosition));

Content -> Contents

> Source/WebKit2/UIProcess/LayerTreeHostProxy.h:58
> +    void setVisibleContentsRect(const WebCore::IntRect&, float scale, const WebCore::FloatPoint& trajectory, const WebCore::FloatPoint& accurateVisibleContentPosition);

Content -> Contents

> Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp:113
> +    newMatrix.translate(m_accurateVisibleContentPosition.x() / m_contentsScale - m_visibleContentsRect.x(), m_accurateVisibleContentPosition.y() / m_contentsScale - m_visibleContentsRect.y());

Add comment

> Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp:163
> +void WebLayerTreeRenderer::setVisibleContentsRect(const IntRect& rect, float scale, const WebCore::FloatPoint& accurateVisibleContentPosition)

Content -> Contents

> Source/WebKit2/UIProcess/WebLayerTreeRenderer.h:105
> +    WebCore::FloatPoint m_accurateVisibleContentPosition;

Content -> Contents

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.