[Webkit-unassigned] [Bug 85118] REGRESSION(r95249): Webkit does not print content of iframe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85118


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Webkit does not print       |REGRESSION(r95249): Webkit
                   |content of iframe.          |does not print content of
                   |                            |iframe
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |Regression
           Priority|P2                          |P1
                 CC|                            |eric at webkit.org
     Ever Confirmed|0                           |1




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org>  2012-04-30 11:33:41 PST ---
> If frame is NULL than "if" on line 651 will fail and program will not go to 652
> If you like I can unroll that too to make it more readable.

Ugh. You're right, but this is a very unusual idiom.

Anyway, this is a wrong place to add this check. A function named "printing()" should tell whether we're printing, not make guesses about how the result will be used, returning a well-intentioned lie. You should either put the check in a different place, or rename the function to reflect what it's actually returning.

Eric, I think that you recently mentioned that PDF expected results don't work, because they are machine specific. Could you please comment on whether this is one of those cases?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.