[Webkit-unassigned] [Bug 84449] DFG JIT is not ARM EABI compatible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84449





--- Comment #4 from Filip Pizlo <fpizlo at apple.com>  2012-04-30 09:41:20 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Interesting, looking at the iOS developer docs, this may be a difference on iOS:
> > 
> > http://developer.apple.com/library/ios/#documentation/Xcode/Conceptual/iPhoneOSABIReference/Articles/ARMv6FunctionCallingConventions.html#//apple_ref/doc/uid/TP40009021-SW1
> > 
> >     * Large data types (larger than 4 bytes) are 4-byte aligned.
> > 
> > We don't want to have to duplicate all these method to have two signatures, I guess we could provide a set of wrappers on non-iOS ARM, but the cleanest approach may just be to fix the callOperation interface to align the arguments correctly.  If this degrades performance (by moving augments from registers to the stack) we can always change the order of args to functions affected to compensate.
> 
> So how about the patch?

I like the general approach of your patch.  Let me know when it's ready to be reviewed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.