[Webkit-unassigned] [Bug 83254] [EFL] Support for Battery Status API on the WebKit-Efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83254


Thiago Marcos P. Santos <tmpsantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tmpsantos at gmail.com




--- Comment #35 from Thiago Marcos P. Santos <tmpsantos at gmail.com>  2012-04-30 03:18:33 PST ---
(In reply to comment #34)
> (From update of attachment 137665 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137665&action=review
> 
> > Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.h:49
> > +    static void getBatteryStatus(void* data, void* replyData, DBusError*);
> 
> Is it really necessary to set as public ? It looks this functions are only used by BatteryClientEfl internally.
> 
> Generally, WebKit doesn't have get prefix. See also : http://www.webkit.org/coding/coding-style.html

Isn't it the opposite?

http://www.webkit.org/coding/coding-style.html#names-setter-getter

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.