[Webkit-unassigned] [Bug 81084] Fix rendering of replaced elements with relative dimensions within a table cell.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 30 00:22:14 PDT 2012


--- Comment #32 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-04-30 00:22:13 PST ---
(In reply to comment #31)
> (From update of attachment 138314 [details])
> I am having second thoughts on the approach as it forces us to walk our ancestor's chain every time you have to recompute your preferred widths which may end up being expensive.

Agree, especially if you don't have a table as parent this would be quite an unnecessary walk. But we require to walk the tree either from RenderReplaced (for containing block) or from Table (for its children).
One possibility could be that we maintain some flag in RenderReplaced/Table but need to analyze how scenarios in which the style for the concerned elements changes dynamically, is going to affect our layout.

> Also you are forcing the replaced element to be it's (maximum) preferred size. IIRC images can be downscaled as long as the intrinsic ratio is kept.

I am sorry but could you please elaborate more on "images can be downscaled as long as the intrinsic ratio is kept".

> I wonder if this couldn't be handled in the table layout code without intruding in the common code.
Have tried to figure out ways of handling the width manipulation in RenderTable/TableCell itself but even there we would have to walk the tree to find a replaced child.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list