[Webkit-unassigned] [Bug 84710] [EFL] [DRT] EventSender doesn't provide correct key string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84710





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-04-29 23:29:16 PST ---
(From update of attachment 139411)
View in context: https://bugs.webkit.org/attachment.cgi?id=139411&action=review

> LayoutTests/ChangeLog:8
> +        Non-visible key string, i.e. right arrow key, shouldn't be displayed on the input field.

I don't understand what is problem in this description.

> Tools/DumpRenderTree/efl/EventSender.cpp:107
> +    KeyEventInfo(const CString& keyName, EvasKeyModifier modifiers, Eina_Bool hasVisibleString)

Please do not use Eina_Bool.

> Tools/DumpRenderTree/efl/EventSender.cpp:116
> +    Eina_Bool hasVisibleString;

We decided to use standard boolean instead of Eina_Bool except for public APIs.

> Tools/DumpRenderTree/efl/EventSender.cpp:447
> +        return new KeyEventInfo(character.get()->ustring().utf8(), modifiers, EINA_TRUE);

Use true instead of EINA_TRUE.

> Tools/DumpRenderTree/efl/EventSender.cpp:449
> +    return new KeyEventInfo(keyName, modifiers, EINA_FALSE);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.