[Webkit-unassigned] [Bug 84708] Web Inspector: Shortcuts screen UI polish

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84708





--- Comment #12 from eustas.bug at gmail.com  2012-04-28 04:24:14 PST ---
(From update of attachment 139019)
View in context: https://bugs.webkit.org/attachment.cgi?id=139019&action=review

>> Source/WebCore/inspector/front-end/KeyboardShortcut.js:64
>> +    Left: { code: 37, name: "<Left>" },           // also NUM_WEST
> 
> Even though they are not currently localized, they should be (at least Left, Right, Up and Down)

Done

>> Source/WebCore/inspector/front-end/ShortcutsScreen.js:58
>> +     * Renders sections to and appends them to the given node.
> 
> We don't comment on code in WebKit unless necessary.

Removed

>> Source/WebCore/inspector/front-end/ShortcutsScreen.js:110
>> +};
> 
> No ; after }

Rolled back here and anywhere it was added.

>> Source/WebCore/inspector/front-end/helpScreen.css:132
>> +    color: #DD0;
> 
> We try to use rgb() notation for colors.

fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.