[Webkit-unassigned] [Bug 84708] Web Inspector: Shortcuts screen UI polish

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84708


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #139019|review?                     |review-
               Flag|                            |




--- Comment #10 from Pavel Feldman <pfeldman at chromium.org>  2012-04-28 00:29:42 PST ---
(From update of attachment 139019)
View in context: https://bugs.webkit.org/attachment.cgi?id=139019&action=review

> Source/WebCore/inspector/front-end/KeyboardShortcut.js:64
> +    Left: { code: 37, name: "<Left>" },           // also NUM_WEST

Even though they are not currently localized, they should be (at least Left, Right, Up and Down)

> Source/WebCore/inspector/front-end/ShortcutsScreen.js:58
> +     * Renders sections to and appends them to the given node.

We don't comment on code in WebKit unless necessary.

> Source/WebCore/inspector/front-end/ShortcutsScreen.js:110
> +};

No ; after }

> Source/WebCore/inspector/front-end/helpScreen.css:132
> +    color: #DD0;

We try to use rgb() notation for colors.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.