[Webkit-unassigned] [Bug 85118] Webkit does not print content of iframe.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 27 23:07:29 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=85118





--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2012-04-27 23:07:29 PST ---
(From update of attachment 139327)
View in context: https://bugs.webkit.org/attachment.cgi?id=139327&action=review

> Source/WebCore/ChangeLog:13
> +        * page/Frame.cpp:
> +        (WebCore::Frame::resizePageRectsKeepingRatio):
> +        * rendering/RenderView.cpp:
> +        (WebCore::RenderView::printing):

Can you explain the changes in ChangeLog?

> Source/WebCore/rendering/RenderView.cpp:652
> +    if (Frame* frame = (m_frameView ? m_frameView->frame() : 0)) {
> +        if (FrameTree* tree = frame->tree()) {

This can't be right - first line explicitly considers a null frame, while the second one deferences the variable without checks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list