[Webkit-unassigned] [Bug 83959] [chromium] Add ability to override user agent string per-WebFrameClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83959





--- Comment #9 from dfalcantara at chromium.org  2012-04-27 15:55:56 PST ---
(In reply to comment #8)
> The inspector hook is in FrameLoader::userAgent (calls into InspectorInstrumentation::applyUserAgentOverride).  I think it would be nice if we could share some code with Inspector (e.g., the override code would live in WebCore and Inspector would call into this code), but not a requirement.  The benefit of sharing would be we wouldn't have to check twice for an override.

I agree that it'd be nice, but it seems that a couple of the other platforms also introduce their own override/custom user agents aside from the Inspector.

> Rather than keep track of the override in NavigationEntry, is it possible to set a bool on FrameLoaderClientImpl (by adding a method on WebFrame that you call when the menu is checked)?  That may use less memory and keep most of the code change in a single repository.

I don't think this will work with the way the feature is defined.  The flag doesn't change on a per-FrameLoaderClientImpl basis; different NavigationEntries can require the flag be set differently, depending on what the user wants it to be set as.  Since multiple NavigationEntries can share the same FrameLoaderClientImpl, we need to store it higher.

If memory is important, one possibility is to globally set a user agent override string like the one currently inside webkit_glue::UserAgentState instead of setting it on a per-Tab basis.  We really only need a single desktop UA string on Android, so it'd still work for us.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.