[Webkit-unassigned] [Bug 85016] REGRESSION(113723): Pressing enter in this list example deletes the whole list

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85016





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2012-04-27 13:06:43 PST ---
(From update of attachment 139241)
View in context: https://bugs.webkit.org/attachment.cgi?id=139241&action=review

> Source/WebCore/editing/CompositeEditCommand.cpp:1272
> +    Node* previousListNode = emptyListItem->isElementNode() ? toElement(emptyListItem)->previousElementSibling(): emptyListItem->previousSibling();
> +    Node* nextListNode = emptyListItem->isElementNode() ? toElement(emptyListItem)->nextElementSibling(): emptyListItem->nextSibling();
> +    if (isListItem(nextListNode) || isListElement(nextListNode)) {

Maybe you can use functions in http://trac.webkit.org/browser/trunk/Source/WebCore/editing/InsertListCommand.cpp?

> Source/WebCore/editing/CompositeEditCommand.cpp:1273
>          // If emptyListItem follows another list item, split the list node.

This comment is no longer accurate. Please update.

> Source/WebCore/editing/CompositeEditCommand.cpp:1285
>          // When emptyListItem does not follow any list item, insert newBlock after the enclosing list node.
>          // Remove the enclosing node if emptyListItem is the only child; otherwise just remove emptyListItem.
>          insertNodeAfter(newBlock, listNode);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.