[Webkit-unassigned] [Bug 84687] Add multichannel support for input of JavaScriptAudioNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84687





--- Comment #8 from Chris Rogers <crogers at google.com>  2012-04-27 12:25:27 PST ---
(From update of attachment 139139)
View in context: https://bugs.webkit.org/attachment.cgi?id=139139&action=review

Xingnan, this looks great.  I have some small changes for the test files to avoid using 6-channels, and instead use 8-channels, since 6-channels will later on be interpreted as 5.1 (see AudioBus::copyFrom() comment with bug link).  Also, I think it's better to rename these test files as I suggest since the names are a bit confusing now.

> LayoutTests/webaudio/javascriptaudionode-2channel-input-expected.txt:1
> +Tests JavaScriptAudioNode 2 channels input.

Tests upmixing a 2-channel source connected to a JavaScriptAudioNode with 8-channel input.

Please re-name test file to: javascriptaudionode-upmix2-8channel-input.html

> LayoutTests/webaudio/javascriptaudionode-2channel-input.html:15
> +description("Tests JavaScriptAudioNode 2 channels input.");

Tests upmixing a 2-channel source connected to a JavaScriptAudioNode with 8-channel input.

> LayoutTests/webaudio/javascriptaudionode-2channel-input.html:19
> +var inputChannels = 6;

Let's switch to 8-channels since 6 channels can be interpreted as 5.1 (and we have a comment with bug in AudioBus::copyFrom() about this mixdown case)

> LayoutTests/webaudio/javascriptaudionode-6channel-input-expected.txt:1
> +Tests JavaScriptAudioNode 6 channels input.

Tests downmixing an 8-channel source connected to a JavaScriptAudioNode with 2-channel input.

Please re-name test file to: javascriptaudionode-downmix8-2channel-input.html

> LayoutTests/webaudio/javascriptaudionode-6channel-input.html:15
> +description("Tests JavaScriptAudioNode 6 channels input.");

Tests downmixing an 8-channel source connected to a JavaScriptAudioNode with 2-channel input.

> LayoutTests/webaudio/javascriptaudionode-6channel-input.html:18
> +var sourceChannels = 6;

Let's switch to 8-channels since 6 channels can be interpreted as 5.1 (and we have a comment with bug in AudioBus::copyFrom() about this mixdown case)

> LayoutTests/webaudio/resources/javascriptaudionode-testing.js:47
> +function checkData(buffer, numberOfChannels, length) {

Please rename test function to checkStereoOnlyData, and add simple comment describing why this will be the case for 2 -> 8 upmix and 8 -> 2 downmix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.