[Webkit-unassigned] [Bug 85057] Add "stack" property to DOMException.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85057





--- Comment #4 from Erik Arvidsson <arv at chromium.org>  2012-04-27 10:18:30 PST ---
(From update of attachment 139205)
View in context: https://bugs.webkit.org/attachment.cgi?id=139205&action=review

> Source/WebCore/bindings/v8/V8Proxy.cpp:579
> +    v8::Handle<v8::Value> message = exceptionObject->Get(v8String("message", isolate));
> +    v8::Handle<v8::Value> error = v8::Exception::Error(message->ToString());

Why do we need the message? Is that required to get the stack?

> Source/WebCore/bindings/v8/V8Proxy.cpp:580
> +    exceptionObject->SetAccessor(v8String("stack", isolate), DOMExceptionStackGetter, 0, error);

What is the intention here? Make sure that setting stack also works since code out there might already do that.

> LayoutTests/fast/dom/DOMException/stack-trace.html:23
> +    }

Please test that the descriptor looks like you expect it to.

It should look something like:

{
  configurable: true,
  enumerable: false,
  get: function () { ... }
  set: function () { ... }
}

> LayoutTests/platform/chromium/fast/dom/DOMException/stack-trace-expected.txt:2
> +layer at (0,0) size 800x600

Please add

layoutTestController.dumpAsText();

we definitely do not care about the layout here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.