[Webkit-unassigned] [Bug 85075] New: check0webkit-style gives false alphabetization error with JSDOMWindowCustom
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 27 10:02:16 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=85075
Summary: check0webkit-style gives false alphabetization error
with JSDOMWindowCustom
Product: WebKit
Version: 528+ (Nightly build)
Platform: Unspecified
OS/Version: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: jmason at rim.com
In https://bugs.webkit.org/show_bug.cgi?id=84982, the stylebot complained about this header include in JSDOMWindowWebSocketCustom.cpp:
23 #include "config.h"
24 #include "JSDOMWindowCustom.h"
25
26 #if ENABLE(WEB_SOCKETS)
27 #include "Frame.h"
28 #include "JSWebSocket.h"
29 #include "Settings.h"
30
31 #if PLATFORM(BLACKBERRY)
32 #include "WebSocket.h"
33 #endif
...
65 #endif
Source/WebCore/bindings/js/JSDOMWindowWebSocketCustom.cpp:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
The header this file implements in JSDOMWindowCustom.h. WebSocket.h contains helper functions. I think the problem is that JSDOMWindowCustom.h does not exactly match the cpp file name, and it's finding "WebSocket" as a substring of the .cpp file name.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list