[Webkit-unassigned] [Bug 85009] ScriptStateProtectedPtr should not keep a strong reference to the context

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85009





--- Comment #7 from jochen at chromium.org  2012-04-27 06:05:00 PST ---
(In reply to comment #6)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #2)
> > If I'm reading this correctly, that code path is only invoked when page is detached, but not when an iframe navigates?
> 
> It should be called on navigation as well but as you pointed out offline there is a scenario when we won't clear the argument and return early from ConsoleMessage::windowCleared because of the following code:
> 
> if (domWindowFromScriptState(m_arguments->globalState()) != window)
>     return;


I added fprintf(stderr, "window cleared\n"); to ConsoleMessage::windowCleared and ran LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation.html, however, the fprintf wasn't triggered during the test.

I think binding the clearing of messages to the page destruction can't work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.