[Webkit-unassigned] [Bug 74921] [EFL] Add new commands for Ewk_Editor_Command.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74921





--- Comment #21 from Michal Pakula vel Rutka <m.pakula at samsung.com>  2012-04-27 03:29:25 PST ---
(From update of attachment 139008)
View in context: https://bugs.webkit.org/attachment.cgi?id=139008&action=review

>> Source/WebKit/efl/ewk/ewk_view.cpp:321
>> +    Eina_Hash* editorCommandHash;
> 
> I didn't understand why this was added to the private data instead of being a static variable inside _ewk_view_editor_command_string_get -- every time a new view is created a new hash will be created with the exact same data.

I had difficulties with calling eina_hash_free on static Eina_Hash inside function. I will move the hash table back to function and replace it with OwnPtr<Eina_Hash>.

>> Source/WebKit/efl/ewk/ewk_view.cpp:1219
>> +                    editorCommands[i].editorCommandString);
> 
> We usually don't wrap at 80 characters, so these lines can be merged.

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.