[Webkit-unassigned] [Bug 83486] [EFL][DRT] EventSender needs implementation of leapForward function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83486





--- Comment #8 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-26 19:39:49 PST ---
(From update of attachment 136723)
View in context: https://bugs.webkit.org/attachment.cgi?id=136723&action=review

> LayoutTests/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).

This line usually comes before the change's longer description.

> Tools/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

Ditto.

> Tools/DumpRenderTree/efl/EventSender.cpp:69
> +    ulong delay;

This value is always set from an int below, so why is it a ulong here?

> Tools/DumpRenderTree/efl/EventSender.cpp:75
> +static const int gDelayedQueueSize = 1024;
> +static DelayedEvent gEventQueue[gDelayedQueueSize];
> +static unsigned gStartOfEventQueue;
> +static unsigned gEndOfEventQueue;

Why do all this manual bookkeeping instead of using a WTF::Vector?

> Tools/DumpRenderTree/efl/EventSender.cpp:154
> +    MouseEventInfo(EvasMouseEvent event, EvasKeyModifier modifiers)
> +        : event(event)
> +        , modifiers(modifiers)
> +        , button(EvasMouseButtonNone)
> +        , horizontalDelta(0)
> +        , verticalDelta(0)
> +    {
> +    }
> +
> +    MouseEventInfo(EvasMouseEvent event, EvasKeyModifier modifiers, EvasMouseButton button)
> +       : event(event)
> +       , modifiers(modifiers)
> +       , button(button)
> +       , horizontalDelta(0)
> +       , verticalDelta(0)
> +    {
> +    }
> +
> +    MouseEventInfo(EvasMouseEvent event, EvasKeyModifier modifiers, int horizontalDelta, int verticalDelta)
> +       : event(event)
> +       , modifiers(modifiers)
> +       , button(EvasMouseButtonNone)
> +       , horizontalDelta(horizontalDelta)
> +       , verticalDelta(verticalDelta)
> +    {
> +    }

This set of constructors could be replaced by a single one:

    MouseEventInfo(EvasMouseEvent event, EvasKeyModifier modifiers, EvasMouseButton button = EvasMouseButtonNone, int horizontalDelta = 0, int verticalDelta = 0)

> Tools/DumpRenderTree/efl/EventSender.cpp:659
> +static void feedOrQueueMouseEvent(MouseEventInfo* eventInfo, bool shouldFeedQueuedEvents)

It's not clear to me when a function is supposed to pass true or false to shouldFeeedQueuedEvents. Can you elaborate?

> Tools/DumpRenderTree/efl/EventSender.cpp:661
> +    if ((gDragMode || gStartOfEventQueue != gEndOfEventQueue || gEventQueue[gEndOfEventQueue].delay)

Ditto about the values of gDragMode (ie. why it is in this check).

> Tools/DumpRenderTree/efl/EventSender.cpp:688
> +    // FIXME: We need to pass additional information with our events, so that
> +    // we could construct correct PlatformWheelEvent. At the moment, max number
> +    // of clicks is 3

Are there tests which are broken due to this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.