[Webkit-unassigned] [Bug 84687] Add multichannel support for input of JavaScriptAudioNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84687





--- Comment #4 from xingnan.wang at intel.com  2012-04-26 19:11:09 PST ---
(From update of attachment 138525)
View in context: https://bugs.webkit.org/attachment.cgi?id=138525&action=review

> Source/WebCore/Modules/webaudio/JavaScriptAudioNode.cpp:65
>          return 0;

Hi Chris, as you said, whether should we handle numberOfOutputChannels == 0?
Now numberOfOutputChannels==0 is not allowed here.

> Source/WebCore/Modules/webaudio/JavaScriptAudioNode.cpp:109
>          m_outputBuffers.append(AudioBuffer::create(this->output(0)->numberOfChannels(), bufferSize(), sampleRate));

Maybe need to check this->output(0)->numberOfChannels() > 0 here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.