[Webkit-unassigned] [Bug 84306] [Qt][WK2] Fixed layers are shaking when zoom level is not 1.0 due to a rounding error.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 14:02:13 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84306





--- Comment #12 from Yael <yael.aharon at nokia.com>  2012-04-26 14:02:13 PST ---
(In reply to comment #11)
> (From update of attachment 139036 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=139036&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:796
> > +    if (layerTreeHostProxy->layerTreeRenderer())
> > +        layerTreeHostProxy->layerTreeRenderer()->setRoundingAdjustment(FloatSize(accurateVisibleRect.x() - visibleRect.x() * scale, accurateVisibleRect.y() - visibleRect.y() * scale));
> 
> Are you sure this should happen in commitScale? Seems like it would cause a small flicker since the rounding adjustment is only needed a bit later, after the committed scale has been actually rendered in the web process.

I did not notice flicker when committing the zoom. We do have to do this after zooming, or else it bits the purpose of aligning the visible content rect all the time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list