[Webkit-unassigned] [Bug 78688] [EFL] Implement Web Audio API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78688


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138755|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Philippe Normand <pnormand at igalia.com>  2012-04-26 08:03:20 PST ---
(From update of attachment 138755)
View in context: https://bugs.webkit.org/attachment.cgi?id=138755&action=review

I think a new iteration of this patch would be needed. Looks good though.

> Source/WebCore/PlatformEfl.cmake:223
>      ${GStreamer-Video_INCLUDE_DIRS}

That's only needed for VIDEO.

> Source/WebCore/PlatformEfl.cmake:232
> +    ${GStreamer-Video_LIBRARIES}

That's only needed for VIDEO.

> Source/WebCore/PlatformEfl.cmake:239
> +    platform/graphics/gstreamer/GStreamerUtilities.cpp

This is needed by both VIDEO and WEB_AUDIO.

> Source/WebCore/PlatformEfl.cmake:240
> +    platform/graphics/gstreamer/GStreamerVersioning.cpp

This is only used by VIDEO but might be needed for both when the WebAudio implementation is ported to GStreamer-1.0... So might be good to move it now too.

> Source/WebKit/efl/ChangeLog:15
> +        (ewk_view_setting_web_audio_set): Querie if the Web Audio API feature is enabled.

typo: Querie

> Source/cmake/OptionsEfl.cmake:135
> +IF (ENABLE_WEB_AUDIO)
> +  IF (NOT ENABLE_VIDEO)
> +    FIND_PACKAGE(GStreamer REQUIRED)
> +    FIND_PACKAGE(GStreamer-App REQUIRED)
> +    FIND_PACKAGE(GStreamer-Base REQUIRED)
> +    FIND_PACKAGE(GStreamer-Interfaces REQUIRED)
> +    FIND_PACKAGE(GStreamer-Pbutils REQUIRED)
> +    FIND_PACKAGE(GStreamer-Plugins-Base REQUIRED)
> +    SET(WTF_USE_GSTREAMER 1)
> +    ADD_DEFINITIONS(-DWTF_USE_GSTREAMER=1)
> +  ENDIF ()
> +  FIND_PACKAGE(GStreamer-Audio REQUIRED)
> +  FIND_PACKAGE(GStreamer-FFT REQUIRED)
> +  ADD_DEFINITIONS(-DWTF_USE_WEBAUDIO_GSTREAMER=1)
> +ENDIF ()

I'm no CMake expert but maybe there's a cleaner way to perform the checks depending on the enabled features?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.